chore(deps): bump web-specs from 2.79.0 to 3.0.0 #10478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
caugner
changed the title
tidoust
force-pushed
the
bump-web-specs
branch
from
c8ed2e4 to
e0d044a
Compare
|
I believe I've now solved the "commit signature" problem. Re-running the check should in theory be enough to turn things green. |
|
@tidoust If you've signed the commit, there'll be a green "Verified" badge next to it, but I can't seem to find it. Did you follow all the instructions from the failed check? You should be able to see if commits have signatures locally by running |
In the new major version of web-specs, spec entries are no longer guaranteed to have a `nightly` property. This change was made to include specs that do not have a public URL, such as ISO specs. The logic that processed web-specs needed to be adjusted accordingly.
tidoust
force-pushed
the
bump-web-specs
branch
from
e0d044a to
a8855dd
Compare
|
I don't know what I did wrong the first time around, but I force-pushing the same commit again seems to have worked... |
caugner
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the new major version of web-specs, spec entries are no longer guaranteed to have a
nightlyproperty. This change was made to include specs that do not have a public URL, such as ISO specs. The logic that processed web-specs needed to be adjusted accordingly.Problem
The code assumed that all spec entries from web-specs had a
nightlyproperty and aseries.nightlyUrlproperty.Solution
The code now only looks under the
nightlyproperty when it is set.Worth noting: if
nightlyis set in web-specs, thenseries.nightlyUrlis set.