Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(macros/MDNSidebar): add Feature status page #10409

Merged
merged 1 commit into from
Feb 28, 2024
Merged

feat(macros/MDNSidebar): add Feature status page #10409

merged 1 commit into from
Feb 28, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jan 30, 2024 •
edited
Loading

Adds a new page Feature_status to the MDNSidebar macro.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner January 30, 2024 03:41
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jan 30, 2024
@OnkarRuikar OnkarRuikar mentioned this pull request Jan 30, 2024
Merged
@caugner caugner marked this pull request as draft January 30, 2024 09:18
@caugner
Copy link
Contributor

caugner commented Jan 30, 2024

Converted to draft, as it's blocked on the content PR.

@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Feb 28, 2024 •
edited
Loading

The content PR has been merged and the page is live now: https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Feature_status

@OnkarRuikar OnkarRuikar marked this pull request as ready for review February 28, 2024 10:03
@OnkarRuikar OnkarRuikar changed the title feat(macro/MDNSidebar): add Technology_status page feat(macro/MDNSidebar): add Feature_status page Feb 28, 2024
bsmth
bsmth approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@caugner caugner changed the title feat(macro/MDNSidebar): add Feature_status page feat(macros/MDNSidebar): add Feature status page Feb 28, 2024
@caugner caugner merged commit a3f8d7e into mdn:main Feb 28, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Feb 28, 2024
Merged
@OnkarRuikar OnkarRuikar deleted the mdn_sidebar branch February 29, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarRuikar @caugner @bsmth