Skip to content

Commit d47c135

Browse files
authored
fix(toolbar): make suggestion diffs theme-friendly (#9322)
* Make backgrounds of ins/del elements in flaws block theme-friendly * Re-add accidentally removed variables
1 parent 732b836 commit d47c135

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

Diff for: client/src/document/toolbar/flaws.scss

+2-3
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,11 @@
3232
}
3333

3434
ins {
35-
background-color: #d4fcbc;
35+
background-color: var(--background-ins);
3636
}
3737

3838
del {
39-
background-color: #fbb;
40-
text-decoration: none;
39+
background-color: var(--background-del);
4140
}
4241

4342
.explanation-notes li {

Diff for: client/src/ui/base/_themes.scss

+4
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
$mdn-theme-light-icon-success,
4141
$alpha: -0.9
4242
)};
43+
--background-del: #{color.adjust($mdn-theme-light-icon-critical, $alpha: -0.5)};
44+
--background-ins: #{color.adjust($mdn-theme-light-icon-success, $alpha: -0.5)};
4345

4446
--border-primary: #{$mdn-theme-light-border-primary};
4547
--border-secondary: #{$mdn-theme-light-border-secondary};
@@ -316,6 +318,8 @@
316318
$mdn-theme-light-icon-success,
317319
$alpha: -0.9
318320
)};
321+
--background-del: #{color.adjust($mdn-theme-light-icon-critical, $alpha: -0.5)};
322+
--background-ins: #{color.adjust($mdn-theme-light-icon-success, $alpha: -0.5)};
319323

320324
--border-primary: #{$mdn-theme-dark-border-primary};
321325
--border-secondary: #{$mdn-theme-dark-border-secondary};

0 commit comments

Comments
 (0)