Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove {{warning}} macro from translated-content #8108

Closed
yin1999 opened this issue Aug 29, 2022 · 1 comment · Fixed by #9591
Closed

Remove {{warning}} macro from translated-content #8108

yin1999 opened this issue Aug 29, 2022 · 1 comment · Fixed by #9591
Labels
l10n-pt-br Issues related to Brazilian Portuguese

Comments

@yin1999
Copy link
Member

yin1999 commented Aug 29, 2022

The {{warning}} macro has been deprecated, let's remove it from translated-content.

This macro will render a note card, we can easily replace it by:

HTML:

<div class="notecard warning">
  <p><strong>{{warning-keyword}}</strong> {{warns}}</p>
</div>

Markdown:

> **{{warning-keyword}}** {{warns}}

The {{warning-keyword}} could be found here (card_warning_label.msgstr field). And the {{warns}} is just the argument of {{warning}} macro.

An example in mdn/content (mdn/content#20015).

@yin1999 yin1999 added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-pt-br Issues related to Brazilian Portuguese labels Aug 29, 2022
@yin1999 yin1999 added this to the Macros removal milestone Aug 29, 2022
@SphinxKnight SphinxKnight removed the l10n-fr Issues related to French content. label Sep 5, 2022
@mfuji09
Copy link
Collaborator

mfuji09 commented Oct 2, 2022

Removed from ja.

@mfuji09 mfuji09 removed the l10n-ja Issues related to Japanese content. label Oct 2, 2022
@yin1999 yin1999 removed the l10n-es Issues related to Spanish content. label Oct 31, 2022
@yin1999 yin1999 removed the l10n-ru Issues related to Russian content. label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants