Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Remove elements with the hidden class, except for <pre>s, web/javascript #2899

Closed
Tracked by #2894
hochan222 opened this issue Oct 28, 2021 · 2 comments
Closed
Tracked by #2894
Labels
l10n-ko Issues related to Korean content.

Comments

@hochan222
Copy link
Member

hochan222 commented Oct 28, 2021

관련 이슈: #2894

목적: web/javascript 폴더 문서에서 <pre> 태그를 제외한 hidden class를 삭제해야합니다.

세부 내용 참고 링크1, 참고 링크2

  • Remove elements with the hidden class, except for <pre>s
    • If the hidden block is a <div> which encloses several <pre>, you should remove the <div> and "propagate" the hidden class to the <pre> block. Also, you should use your best judgement to assess if this part actually needs to be hidden
    • You're most likely to find <div>s and <p>s with this class
    • In the end, checking class=".*?hidden.*?" should only report <pre> elements

원활한 리뷰를 위해 다음 사항을 지켜주세요.

  • 한 PR당 최대 변경 파일의 개수는 20개를 넘지 않게 해주세요.
@hochan222 hochan222 changed the title Remove elements with the hidden class, except for <pre>s [ko] Remove elements with the hidden class, except for <pre>s, web/javascript Oct 28, 2021
@hochan222 hochan222 added the l10n-ko Issues related to Korean content. label Oct 28, 2021
@SnowMarble
Copy link
Contributor

image
class="[^"]*hidden[^"]*"으로 검색했을 때 hidden 클래스를 가진 태그가 하나도 없습니다. 확인 후 이슈를 닫아주시면 될것 같습니다!

@hochan222
Copy link
Member Author

@kraccoon-dev 님 확인 감사드립니다. 좋은 하루 보내세요 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

No branches or pull requests

2 participants