Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect l10n.sourcecommit meta data #12128

Closed
hochan222 opened this issue Mar 11, 2023 · 10 comments
Closed

Incorrect l10n.sourcecommit meta data #12128

hochan222 opened this issue Mar 11, 2023 · 10 comments
Assignees
Labels
effort: medium Task is a medium effort. l10n-es Issues related to Spanish content. l10n-ja Issues related to Japanese content.

Comments

@hochan222
Copy link
Member

Issue

The hash value of the source commit in meta data is incorrect. In most cases, there is no hash in the history for the same file in the content repo.

Files Info

ja

ja/glossary/falsy: ec5cdbe5e3e0198f60a537c7d4a9d31edab50920
ja/web/api/htmlelement: d954e1df58f18f15181bfe33ac64dfad9627f485
ja/web/api/mediastream_recording_api: 60c1df4b8b6ed30b2baec49ec3e21a1648a0ba86
ja/web/api/pointerevent: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/serviceworkerglobalscope: e540d79b5bc8893cdcd0b65ec498a6e2c22cfcfa
ja/web/api/uievent: 70ab349bf0271762d5d8d03b3cdf723fd7d13326
ja/learn/tools_and_testing/understanding_client-side_tools/overview: 99eb07dc4987d2c2f4982e81c046c9abbe827665
ja/mdn/community/contributing/security_vulnerability_response: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/web/http/resources_and_specifications: 07b16eba30c0f343199170145b57440f66501453
ja/mdn/writing_guidelines/howto/images_media: 294dc5cb436d4f86ed789be8fded3ff615768fb0
ja/mdn/writing_guidelines/page_structures/macros: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/mdn/writing_guidelines/page_structures/page_types: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/web/javascript/guide/expressions_and_operators: 6ebc97ff44612ef04d2cde60bfe9049bc8482bb5
ja/web/api/document/pointerlockerror_event: d4619276d67ca1ee02bd964d884ec52c2aa2ad4by
ja/web/api/element/lostpointercapture_event: 3efb6cc0c72738d127ccd0829196b9dd24a726a6
ja/glossary/html: 2ac7419230e51f9bca905f4ef14d9e44c4dd6dba
ja/web/api/html_drag_and_drop_api: 7e43ff6a4a712f9e4477a70c453ba116a4dd6601
ja/mdn/community/contributing/translated_content: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/web/api/element/pointerleave_event: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/element/pointerup_event: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/element/pointerover_event: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/element/pointerout_event: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/element/setpointercapture: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/html_drag_and_drop_api/file_drag_and_drop: 7e43ff6a4a712f9e4477a70c453ba116a4dd6601
ja/web/api/mediastream_recording_api/using_the_mediastream_recording_api: 60c1df4b8b6ed30b2baec49ec3e21a1648a0ba86
ja/web/api/pointer_events/multi-touch_interaction: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/pointer_events/pinch_zoom_gestures: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/element/pointermove_event: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/pointerevent/getcoalescedevents: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/pointerevent/isprimary: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/pointerevent/pointerid: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/pointerevent/pointertype: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/pointerevent/pressure: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/pointerevent/tangentialpressure: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/element/pointerenter_event: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/uievent/inituievent: 70ab349bf0271762d5d8d03b3cdf723fd7d13326
ja/web/api/uievent/view: 70ab349bf0271762d5d8d03b3cdf723fd7d13326
ja/web/api/workerglobalscope/importscripts: 0fe2d3ee23b1b23be971d42c7c56729bd23a3f83
ja/web/api/workerglobalscope/languagechange_event: 0fe2d3ee23b1b23be971d42c7c56729bd23a3f83
ja/web/api/element/pointercancel_event: 3efb6cc0c72738d127ccd0829196b9dd24a726a6
ja/web/api/window/vrdisplaypresentchange_event: f01646c40eb0c51d267c54d0ae77d912fde1cb85
ja/mdn/writing_guidelines/howto/write_an_api_reference/sidebars: 708baf34eabb75789bcd3314a6879da3702024d1
ja/mdn/writing_guidelines/page_structures/macros/commonly_used_macros: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/mdn/writing_guidelines/page_structures/page_types/api_event_subpage_template: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/mdn/writing_guidelines/page_structures/page_types/api_method_subpage_template: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/mdn/writing_guidelines/page_structures/page_types/api_property_subpage_template: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/mdn/writing_guidelines/page_structures/page_types/api_reference_page_template: 73dd350fd93be16bee3b9a6b860757265209b4b7
ja/web/html/element/input/range: ad516ec6fedfc6dd62628b7a4438e215351f5b7e
ja/web/javascript/reference/global_objects/sharedarraybuffer: 1c7cd798570353939e221d4282af014ea04726ac
ja/web/javascript/reference/global_objects/math/e: df8a3ccf1a3368beb140455631059cd4f24d80f0
ja/web/api/pointerevent/twist: 708baf34eabb75789bcd3314a6879da3702024d1
ja/web/api/workerglobalscope/location: 0fe2d3ee23b1b23be971d42c7c56729bd23a3f83
ja/web/api/pointer_events/using_pointer_events: 708baf34eabb75789bcd3314a6879da3702024d1

es

es/glossary: ed947b2c608428b62a60f07d09dc543f732dc09bed947b2c608428b62a60f07d09dc543f732dc09b
es/web/api/event/event: 4e233c16c6f0d347972c5c762f5b836318a461244e233c16c6f0d347972c5c762f5b836318a46124
es/web/api/element/closest: a122e87245c624ba56197641b4d7b21b643a6021a122e87245c624ba56197641b4d7b21b643a6021
es/learn/javascript/asynchronous/introducing: 05d8b0eb3591009b6b7fee274bb7ed1bc5638f1805d8b0eb3591009b6b7fee274bb7ed1bc5638f18
es/web/api/navigator: 165b70e57270af4ba85526d92cce74d51d12c39d165b70e57270af4ba85526d92cce74d51d12c39d
es/web/css/height: abcebf471d56ef12239e2565f26d952e8a8cab2eabcebf471d56ef12239e2565f26d952e8a8cab2e

Other supporting information

Check with the source-commit-report.txt file generated in the PR below.

mdn/yari#8338

@hochan222 hochan222 changed the title Content suggestion: <TITLE OF SUGGESTION> Incorrect l10n.sourcecommit Mar 11, 2023
@hochan222 hochan222 added l10n-ja Issues related to Japanese content. l10n-es Issues related to Spanish content. effort: medium Task is a medium effort. labels Mar 11, 2023
@hochan222 hochan222 changed the title Incorrect l10n.sourcecommit Incorrect l10n.sourcecommit meta data Mar 11, 2023
@hochan222
Copy link
Member Author

cc. @mdn/yari-content-es @mdn/yari-content-ja

@mfuji09
Copy link
Collaborator

mfuji09 commented Mar 12, 2023

@hochan222
Thank you for reporting! I'll try to fix files in ja locale.
By the way, is there a way to report the all files containing bad commit IDs? I want to check again later.

@hochan222
Copy link
Member Author

It hasn't been merged yet, but you can check the automatically generated report file(source-commit-report.txt) when entering the _translations/differences page in mdn/yari#8338 PR branch.

When the command below fails, it is appended to the report file.

git rev-list --count ${commitHash}..HEAD -- ${parentFilePath}

@Graywolf9
Copy link
Contributor

Thank you so much! @hochan222

I'm looking that the es files is throwing the error due to the length of the hash, but the hash is correct

es/glossary/index.md

ed947b2c608428b62a60f07d09dc543f732dc09bed947b2c608428b62a60f07d09dc543f732dc09b

en-us/glossary/index.md

ed947b2c608428b62a60f07d09dc543f732dc09b

@mfuji09
Copy link
Collaborator

mfuji09 commented Mar 14, 2023

I have created pull requests for the all files in ja.
It will be fixed when they are merged.

@mfuji09
Copy link
Collaborator

mfuji09 commented Mar 19, 2023

@hochan222
All of ja files are fixed.
Can you check it again?

@hochan222
Copy link
Member Author

hochan222 commented Mar 20, 2023

2023/03/21 Errors are currently reported only for the paths below for all locales.

es/glossary: ed947b2c608428b62a60f07d09dc543f732dc09bed947b2c608428b62a60f07d09dc543f732dc09b
es/learn/javascript/asynchronous/introducing: 05d8b0eb3591009b6b7fee274bb7ed1bc5638f1805d8b0eb3591009b6b7fee274bb7ed1bc5638f18
es/web/api/element/closest: a122e87245c624ba56197641b4d7b21b643a6021a122e87245c624ba56197641b4d7b21b643a6021
es/web/api/navigator: 165b70e57270af4ba85526d92cce74d51d12c39d165b70e57270af4ba85526d92cce74d51d12c39d
es/web/api/event/event: 4e233c16c6f0d347972c5c762f5b836318a461244e233c16c6f0d347972c5c762f5b836318a46124
es/web/css/height: abcebf471d56ef12239e2565f26d952e8a8cab2eabcebf471d56ef12239e2565f26d952e8a8cab2e

@mfuji09 All solved for ja-locale! Thanks for solving it :)

I'm looking that the es files is throwing the error due to the length of the hash, but the hash is correct

@Graywolf9 Git is only dealing with 40 digit hashes. Currently es-locale has the same 40 digit hash repeated twice.

In the picture below, the source commit behind function I implemented handles only the 40-digit git hash correctly, so the page may not be able to track the source commit behind well. (If merged) Thank you.

image

Have a nice day :)

This was referenced Mar 21, 2023
@Graywolf9
Copy link
Contributor

Thank you so much! @hochan222 this should be done in #12315

@Graywolf9
Copy link
Contributor

Hello! @hochan222, #12315 has been merge, if there is something else to do, please let me know

Thank you so much for all your work!

@Graywolf9 Graywolf9 self-assigned this Mar 30, 2023
@hochan222
Copy link
Member Author

Thank you all for your hard work. I checked the corrections you made.

It's still under development, so it's not perfect, so I'll reopen it when I find a problem after the development is complete!

Have a good day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Task is a medium effort. l10n-es Issues related to Spanish content. l10n-ja Issues related to Japanese content.
Projects
None yet
Development

No branches or pull requests

3 participants