Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: macro depreciation: ServiceWorkerSidebar to be removed #10170

Closed
SphinxKnight opened this issue Nov 25, 2022 · 3 comments · Fixed by #10834
Closed

Chore: macro depreciation: ServiceWorkerSidebar to be removed #10170

SphinxKnight opened this issue Nov 25, 2022 · 3 comments · Fixed by #10834
Labels
l10n-pt-br Issues related to Brazilian Portuguese
Milestone
Macros removal

Comments

@SphinxKnight
Copy link
Member

SphinxKnight commented Nov 25, 2022 •
edited
Loading

Hello all,

Per mdn/yari#7645, {{ServiceWorkerSidebar}} is now deprecated and should be replaced with {{DefaultAPISidebar}}.

@yin1999 already took care of zh in #10163 🙇

Here are the 12 remaining occurrences:

  • 2 for @mdn/yari-content-es
  • 2 for @mdn/yari-content-fr
  • 2 for @mdn/yari-content-ja
  • 2 for @mdn/yari-content-ko
  • 2 for @mdn/yari-content-pt-br
  • 2 for @mdn/yari-content-ru

This should be quite simple to do, but please let me know if you need help :)
@SphinxKnight SphinxKnight added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Nov 25, 2022
@SphinxKnight SphinxKnight added this to the Macros removal milestone Nov 25, 2022
@Graywolf9 Graywolf9 mentioned this issue Nov 25, 2022
Merged
@Graywolf9
Copy link
Contributor

Graywolf9 commented Nov 25, 2022 •
edited
Loading

Taking care of it in #10176 for es

Thank you @SphinxKnight

@yin1999 yin1999 removed the l10n-es Issues related to Spanish content. label Nov 26, 2022
@notJoon notJoon mentioned this issue Nov 26, 2022
Merged
@notJoon
Copy link
Contributor

notJoon commented Nov 26, 2022

@SphinxKnight
just finished in #10188 ko
thank you

@YujiSoftware YujiSoftware mentioned this issue Nov 26, 2022
Merged
@yin1999 yin1999 removed the l10n-ko Issues related to Korean content. label Nov 29, 2022
@sashasushko sashasushko mentioned this issue Nov 30, 2022
Merged
@sashasushko
Copy link
Member

@SphinxKnight done for RU

@cw118 cw118 removed the l10n-ru Issues related to Russian content. label Nov 30, 2022
This was referenced Dec 1, 2022
Merged
Merged
@wbamberg wbamberg mentioned this issue Dec 7, 2022
Closed
7 tasks
@cw118 cw118 removed the l10n-fr Issues related to French content. label Dec 22, 2022
@yin1999 yin1999 removed the l10n-ja Issues related to Japanese content. label Dec 31, 2022
@yin1999 yin1999 mentioned this issue Dec 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
l10n-pt-br Issues related to Brazilian Portuguese
Projects
None yet
Milestone
Macros removal
Development

Successfully merging a pull request may close this issue.

chore(pt-BR): remove {{ServiceWorkerSidebar}} macros yin1999/translated-content
6 participants
@SphinxKnight @sashasushko @notJoon @Graywolf9 @yin1999 @cw118