-
Notifications
You must be signed in to change notification settings - Fork 142
WebAPI updates for Firefox 82 #3731
Comments
@chrisdavidmills This one ready for review. |
@chrisdavidmills This one ready for review. |
@chrisdavidmills This one is now ready for your review |
|
Thanks @hamishwillee. Looks like most of this has been done fine. I have made a few edits to the pages to tighten up the prose a bit, and made some suggestions on improving the BCD for the MediaSession API. I think it'd be great if @Rumyra looked at the MediaSession docs and thought about if anything is missing, if it needs better examples, etc. |
@chrisdavidmills Thank you. FYI, have acted on your BCD suggestions for MediaSession API - waiting for review Thanks for tidying prose; I did various changes along the way too, but mostly "to my taste". Agree, very pleased if @Rumyra look has a look too. @Rumyra note that the BCD for MediaPositionState has now been updated, but until that goes in you'll see the table missing in the docs. |
Thanks both, I'll check out the MediaSession docs now |
Cool, cheers @Rumyra , and thanks @hamishwillee for your continued work. |
Just moved this back whilst I get some good code examples in |
I've written a demo and added a pr to dom-examples for it... I've updated all of the code examples within the API pages to be consistant and show the relevant code where appropriate. The task for the future is to write up the demo as a tutorial (added as a task in web apis project), for which I have already made notes 👍 |
@Rumyra the demo is great, and works really nicely on Chrome and Firefox. The only thing I was wondering about is — isn't one of the main points of the Media Session API to provide meta data about tracks that can be easily shown in notifications? therefore, would it make sense to add some Notifications API code to the demo so that when a track changes, a system notification is shown to display details of the next track? |
@Rumyra hi Ruth! I can't remember exactly what was said when we chatted about this, but I believe that we agree that the MediaSession docs were complete for their basic purpose, right? And that anything left, like adding a basic tutorial and figuring out a more advanced version with notifications or whatever could be left to an advanced tutorial? In which case, shall we close this one, and then you can submit sprint issues for the tutorials? |
Yes that's it :D I've added an issue to the Web APIs project, so once we've cleared the release issues I can go back and spend some more time making an explainer - see #3797 |
@Rumyra perfect, thanks! |
Just moved this to 'done' as it's closed 👍 |
Acceptance criteria
The following bugs are dev-doc-complete, BCD is updated, an entry to Firefox release notes is added, experimental features page is updated, the content has been reviewed as needed.
window.name
; needs page updating to talk about it, maybe a small example, and a BCD update. Maybe also see if there is anywhere in our security pages that it would warrant a mention?Document.execCommand()
calls by default in release builds — I think this just needs a BCD entry, and nmaking sure this is noted on theexecCommand()
page somewhere sensible.Total estimate: 2 days
The text was updated successfully, but these errors were encountered: