fix(build/parser): parse empty string args for macros as None
s
#88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
replace empty string args for macos with
None
sMotivation
In mdn/content, we are used to use empty string to represent the argument is not provided, which should be
None
instead ofSome(EmptyString)
. But we have use some judgement likeif let Some(anchor) = anchor
to check if the string argument is provided. This will evaluate totrue
as the judgement encounters a string.I found an incorrect case in
/en-US/docs/Mozilla/Add-ons/WebExtensions/API/pageAction/onClicked
page:There is a hash symbol at the end of the link text.
I think the easiest solution is to replace the empty string args with
None
s. As we use similar logic to the above to determine whether the parameters are provided in many macos. Some cases (Maybe not all of them):I haven't fully tested this change, so I'm not sure if it will break any pages. If you have any ideas, please let me know.