-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit BCD link in SeeCompatTable macro if page has no BCD frontmatter/section #174
Comments
Shouldn't this be a yari bug? We know that we want to be able to mark API pages as secure context, experimental, deprecated, but that generally we to not want to include browser compatibility information in them. The discussion essentially says we need some way to squelch the link. I like jpmedley suggestion of doing this based on the content, though I would do this based on the existence of a heading I might add a note to the discussion. |
This can be handled in yari by checking if the page doesn't have |
MDN URL
https://developer.mozilla.org/en-US/docs/Web/API/WebUSB_API
What specific section or headline is this issue about?
Link in the page banners to browser compat section is broken
What information was incorrect, unhelpful, or incomplete?
Some API landing pages with
{{SeeCompatTable}}
or{{securecontext_header}}
macro, which generate the following banner text, include a link to the "Browser comparability" section, but the page does not have abrowser-compat
key in the front matter. So the link to the browser compat section is broken:and
What did you expect to see?
Working link or no link
Do you have any supporting links, references, or citations?
At the moment, the issue seems to exist in only two landing pages (broken link to BCD section from the banner):
The following page does not have the
browser-compat
key but the "Browser compatibility" section is hand-written:Do you have anything more you want to share?
This issue has been brought up before in a discussion (https://github.com/orgs/mdn/discussions/564#discussioncomment-1554227) and a somewhat related issue mdn/content#17550.
MDN metadata
Page report details
en-us/web/api/webusb_api
The text was updated successfully, but these errors were encountered: