Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlossaryDisambiguation macro doesn't render macros in fetched text. #160

Open
3 tasks done
hamishwillee opened this issue Feb 16, 2023 · 2 comments
Open
3 tasks done
Assignees
Labels
effort: medium This task is a medium effort. idle Issues and pull requests with no activity for three months. p3 We don't have visibility when this will be addressed.

Comments

@hamishwillee
Copy link

hamishwillee commented Feb 16, 2023

Summary

The macro GlossaryDisambiguation pulls in the first lines of "sub topics". So for example mdn/content#24350 adds a glossary for the term boolean that pulls in definitions from the first lines of the topics for booleans in HTML.

In the image you can see Enumerated is just a word. However in the original it is a glossary link to the Enumerated topic, with link text "enumerated attribute" - that is what should be shown (and I have put in place in the image so you can see it)

image

URL

mdn/content#24350

Reproduction steps

Just run the https://pr24350.content.dev.mdn.mozit.cloud/en-US/docs/Glossary/Boolean page (or https://developer.mozilla.org/en-US/docs/Glossary/Boolean once that updates).

Expected behavior

Macros in imported text should fully expand as in the original.

Actual behavior

The name of the glossary term is used, not the macro link text.

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Windows

Screenshot

No response

Anything else?

No response

Validations

@caugner caugner self-assigned this Feb 20, 2023
@caugner caugner added the p3 We don't have visibility when this will be addressed. label Feb 20, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jan 24, 2024
@caugner caugner added the effort: medium This task is a medium effort. label Jun 24, 2024
@caugner caugner removed their assignment Jun 24, 2024
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Jun 25, 2024
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jul 26, 2024
@caugner caugner transferred this issue from mdn/yari Mar 14, 2025
@caugner
Copy link
Contributor

caugner commented Mar 14, 2025

Moved to rari, as this is still an issue on https://developer.mozilla.org/en-US/docs/Glossary/Boolean:

The source is:

A **boolean attribute** in ARIA is an {{Glossary("Enumerated", "enumerated attribute")}} that includes `true` or `false` in the enumerated list.

Expected vs. actual:

--- Actual
+++ Expected

- A **boolean attribute** in ARIA is an Enumerated that includes `true` or `false` in the enumerated list.
+ A **boolean attribute** in ARIA is an enumerated attribute that includes `true` or `false` in the enumerated list.

@fiji-flo
Copy link
Contributor

Fixed via 8de1517

@fiji-flo fiji-flo self-assigned this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium This task is a medium effort. idle Issues and pull requests with no activity for three months. p3 We don't have visibility when this will be addressed.
Projects
None yet
Development

No branches or pull requests

3 participants