Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDN Border-image generator: Move border-image-source to the end in CSS Code output #93

Open
Tracked by #180
strarsis opened this issue Nov 6, 2022 · 5 comments
Labels
effort: small Task is a small effort. enhancement Improves an existing feature. idle Issues and pull requests with no activity for three months. tool: border-image-generator

Comments

@strarsis
Copy link

strarsis commented Nov 6, 2022

Currently, properties are listed after the border-image-source property, like border-style.
As border-image-source contains the encoded image, it can become quite lengthy, and often the image is referenced differently (e.g. by URL or by some asset management in the build step). Hence the developer may copy everything until border-image-source and then just skip everything else, as there can be a lot to scroll down - and thereby easily miss other important properties, as border-style (which is required by Chrome to make the border image actually visible).

@strarsis strarsis changed the title MDN Border Image Generator: Move border-image-source to the end in CSS Code output MDN Border-image generator: Move border-image-source to the end in CSS Code output Nov 6, 2022
@strarsis strarsis changed the title MDN Border-image generator: Move border-image-source to the end in CSS Code output MDN Border-image generator: Move border-image-source to the end in CSS Code output Nov 6, 2022
@jsnkuhn
Copy link
Contributor

jsnkuhn commented Jan 9, 2023

so current order is:

border-image-slice: 27 27 27 27;
border-image-width: 20px 20px 20px 20px;
border-image-outset: 0px 0px 0px 0px;
border-image-repeat: stretch stretch;
border-image-source: url("border-image-1.png");
border-style: solid; 

Personally what I usually do is put the border declaration up front so i don't forget it followed by the image-source. So that would be this:

border-style: solid;
border-image-source: url("border-image-1.png");
border-image-repeat: stretch stretch;
border-image-slice: 27 27 27 27;
border-image-width: 20px 20px 20px 20px;
border-image-outset: 0px 0px 0px 0px;

FYI, have confirmed that the border-style requirement in Chrome is a bug that will hopefully be getting fixed this year. By the spec border-image-width alone should be enough to paint the border.

@Rizalsabuga

This comment was marked as off-topic.

@Rizalsabuga

This comment was marked as off-topic.

@Rizalsabuga

This comment was marked as spam.

@caugner caugner added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 10, 2023
@caugner
Copy link
Contributor

caugner commented Oct 11, 2023

Currently, the border properties are roughly ordered by appearance in the tool, except for border-image-source. It's true that a different order could make more sense.

@caugner caugner added enhancement Improves an existing feature. effort: small Task is a small effort. tool: border-image-generator and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 11, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: small Task is a small effort. enhancement Improves an existing feature. idle Issues and pull requests with no activity for three months. tool: border-image-generator
Projects
None yet
Development

No branches or pull requests

4 participants