Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include detailed information about scaling on window.devicePixelRatio reference page #29682

Open
chrisdavidmills opened this issue Oct 17, 2023 · 1 comment
Labels
area: DOM/CSSOM Content:WebAPI Web API docs effort: medium This task is a medium effort. goal: completeness (Experiment label) Issues about content missing important/relevant details. needs BCD update

Comments

@chrisdavidmills
Copy link
Contributor

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/Window/devicePixelRatio

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

(this came up during a review of my Window Management API content PR: #28851)

Technically, the window.devicePixelRatio value also includes scaling of the window itself, i.e. page zoom (at least on Chrome and Firefox on Mac, but not on Safari desktop...), while screen.devicePixelRatio does not.

We probably ought to update the window.devicePixelRatio page at some point to mention this, provide details, and include appropriate compat data to show which browsers include page zoom and which don't.

What did you expect to see?

Clear, explicit information about the effects of browser zoom on the devicePixelRatio value. At the moment it is sort of mentioned in a roundabout way in the examples, but not clearly tackled.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

@chrisdavidmills chrisdavidmills added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 17, 2023
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 17, 2023
@caugner caugner added goal: completeness (Experiment label) Issues about content missing important/relevant details. effort: medium This task is a medium effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Nov 3, 2023
@Josh-Cena
Copy link
Member

Seems related to https://bugs.webkit.org/show_bug.cgi?id=236232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DOM/CSSOM Content:WebAPI Web API docs effort: medium This task is a medium effort. goal: completeness (Experiment label) Issues about content missing important/relevant details. needs BCD update
Projects
None yet
Development

No branches or pull requests

3 participants