Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with "Recipe: Media objects": (short summary here please) #2844

Closed
NitschkeM opened this issue Mar 4, 2021 · 3 comments · Fixed by #2997
Closed

Issue with "Recipe: Media objects": (short summary here please) #2844

NitschkeM opened this issue Mar 4, 2021 · 3 comments · Fixed by #2997
Assignees
Labels
Content:CSS Cascading Style Sheets docs

Comments

@NitschkeM
Copy link

MDN URL: https://developer.mozilla.org/en-US/docs/Web/CSS/Layout_cookbook/Media_objects

What information was incorrect, unhelpful, or incomplete?

The css 'code' contains style rules which does not match any html elements.

Specific section or headline?

Under headline: The Recipe.
Scroll down to bottom.
Copy Code --> This is the code this post refers to.

The css code includes the following style rule:
.media-flip > .media {
grid-column-start: 1;
}
But no html markup matches the selector list.
There are no elements of class .media that are direct children of an element of class .media-flip.
I.e. the code does nothing - as far as I can tell.

What did you expect to see?

I would expect the css selectors to match some html markup.

Did you test this? If so, how?

Deduction from my limited understanding of html and css.

Induction including the following observations:
I observed the page in action in a browser with the code in question active.
I then commented out the code and observed again.
I could not see any difference between these two observations.

MDN Content page report details
@rachelandrew rachelandrew self-assigned this Mar 4, 2021
@rachelandrew
Copy link
Collaborator

I'll take a look, also those code examples are all displaying in very small iframes so I'll sort that out too!

@Ryuno-Ki Ryuno-Ki added the Content:CSS Cascading Style Sheets docs label Mar 4, 2021
@NitschkeM
Copy link
Author

Cool cool, good luck =]

@rachelandrew
Copy link
Collaborator

This is fixed - thanks for reporting it, I think that was some redundant code. I've also made a PR above to sort out the squashed demos so they should be easier to read once it is merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants