Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML code guidelines are conflicting with Prettier format #20523

Closed
rubiesonthesky opened this issue Sep 10, 2022 · 5 comments
Closed

HTML code guidelines are conflicting with Prettier format #20523

rubiesonthesky opened this issue Sep 10, 2022 · 5 comments
Labels
Content:Meta Content in the meta docs

Comments

@rubiesonthesky
Copy link
Contributor

HTML code guidelines page says this about trailing slashes:

Don't include XHTML-style trailing slashes for empty elements because they're unnecessary and slow things down. They can also break old browsers if you're not careful (although from what we can recall, this hasn't been a problem since Netscape 4).

But Prettier is now inserting those trailing slashes all around html examples. I agree that it would be "cleaner" without trailing slashes but it's not possible to disable them in Prettier. So maybe this section should be revisited or removed?

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Sep 10, 2022
@teoli2003
Copy link
Contributor

teoli2003 commented Sep 10, 2022

Yes, feel free to open a PR to remove it. We'll review it and see if we have a consensus.

@Josh-Cena
Copy link
Member

I have a feeling of deja vu that you (or someone else) have brought this up in the past, but I can't find the discussion... Was it on Matrix? GitHub discussions?

@rubiesonthesky
Copy link
Contributor Author

I have a feeling of deja vu that you (or someone else) have brought this up in the past, but I can't find the discussion... Was it on Matrix? GitHub discussions?

Yes, I asked in Matrix few days ago. :)

@Josh-Cena
Copy link
Member

Ah, see it now👍

@Josh-Cena Josh-Cena added Content:Meta Content in the meta docs and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Sep 10, 2022
@teoli2003
Copy link
Contributor

(I also had this impression of déjà-vu :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Meta Content in the meta docs
Projects
None yet
Development

No branches or pull requests

3 participants