Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML] Option to Unhide Entry of Password #10855

Closed
6 of 7 tasks
Rumyra opened this issue Nov 29, 2021 · 2 comments
Closed
6 of 7 tasks

[HTML] Option to Unhide Entry of Password #10855

Rumyra opened this issue Nov 29, 2021 · 2 comments
Assignees
Labels
Content:HTML Hypertext Markup Language docs fx release archive A closed issue relating to firefox release notes for developers. needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Nov 29, 2021

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
    or
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Not entirely sure why this bug has dev-doc-needed without reading the long thread. So this requires a read of the bug itself and a judgement on whether any doc updates are actually needed for it. Possibly something we mention in BCD?

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=502258

@Rumyra Rumyra added Content:HTML Hypertext Markup Language docs Firefox 96 labels Nov 29, 2021
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 29, 2021
@hamishwillee
Copy link
Collaborator

This adds support for show password icon in <input type="password"> inputs behind the preference layout.forms.input-type-show-password-button.enabled.
image

This is not defined in a spec - the closest thing is this issue: whatwg/html#7293
There is some concern about the interaction with sites that implement this feature themeselves, and how this might interact with the other "sub controls" that might appear on some browsers.

My feeling is that it is too early to document this "properly". In #11171 what I have done is added experimental feature and also noted that it is a possible that this kind of behaviour might exist for a browser.

IMO No BCD yet. I don't necessarily see this any kind of "compatibility" issue yet, since the the behaviour is not specced and the concerns about how other browsers might work with this are still in discussion.

Upshot, this this is done.

@hamishwillee hamishwillee self-assigned this Dec 13, 2021
@Rumyra
Copy link
Collaborator Author

Rumyra commented Dec 13, 2021

Great - thank you @hamishwillee

@Rumyra Rumyra closed this as completed Dec 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 96 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:HTML Hypertext Markup Language docs fx release archive A closed issue relating to firefox release notes for developers. needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

3 participants