-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish all tests #14
Comments
it would probably make sense to leave that kind of edge case testing to However, I don't think we need to be too thorough, as this can easily turn into testing the wrapped array's behavior, which I don't think we should do (drawing that line can be hard, though). |
With
What I meant about testing edge cases is that there may still be edge cases where what the wrapper does needs to be tested. For instance, when all elements of a reducing operations are masked, the result should be masked (according to precedent). That may not already come up in its own very often. Also, originally, I was generating random values with the uniform distribution, so after conversion to integer dtypes there was only 0 and 1. This might be enough to ensure correct behavior of the masked part, but maybe not for functions like I've already parametrized the tests over multiple backends and all dtypes and found some small issues. I just mean to take another pass and think about each test again when I'm not sprinting to get something written. |
In the first pass at writing tests, I'm interested in demonstrating that the function is mostly correct.
Take a second pass to polish, making sure that each function is bulletproof. This includes testing with multiple backends and all relevant dtypes. It's also important to check that the (random) numerical value used in tests have an appropriate distribution for exercising the function, and we may need to add tests of edge cases.
The text was updated successfully, but these errors were encountered: