Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4: build failing with latest bootstrap#v4-dev #1045

Closed
rosskevin opened this issue Jul 26, 2016 · 15 comments
Closed

V4: build failing with latest bootstrap#v4-dev #1045

rosskevin opened this issue Jul 26, 2016 · 15 comments
Milestone

Comments

@rosskevin
Copy link
Contributor

rosskevin commented Jul 26, 2016

Bootstrap didn't publish umd or src in the latest builds:
twbs/bootstrap#18934

New builds are currently not working. I do see that they intend to publish js modules in alpha 3, just not sure what to do in the interim.

Unfortunately, npm isn't pulling the full repo source like it used to based on "bootstrap": "twbs/bootstrap#v4-dev", otherwise I could just add their js source to our transpilation pipeline.

We need to get back to a place where either:
a) bootstrap is publishing modules in the npm package; or
b) npm will pull the js source from the repo like I instruct it to! (not sure why this has changed)

@rosskevin
Copy link
Contributor Author

@FezVrasta that's all the time I can give this today. If you can solve b) above, I'm pretty sure I can get the build working again. As-is, I have no js source being pulled from the bs4 repo and I have no idea why.

If alpha 3 is published, that is our best bet and they have promised that this is solved for that release.

@FezVrasta
Copy link
Contributor

Sorry what's the point b?

Imho there aren't problems in waiting for BS to fix on their side, no rush.

@rosskevin
Copy link
Contributor Author

b) npm will pull the js source from the repo like I instruct it to! (not sure why this has changed)

@rosskevin
Copy link
Contributor Author

4.0.0-alpha.3 npm package does not contain es6 sources, a cjs or umd bundle.

@FezVrasta
Copy link
Contributor

shit :/ will have to wait then..

@FezVrasta FezVrasta added v4 and removed v4 labels Jul 31, 2016
@FezVrasta
Copy link
Contributor

Our blocking issue is being tracked at twbs/bootstrap#20418

@FezVrasta
Copy link
Contributor

FezVrasta commented Aug 1, 2016

Updating the status here:

As temporary workaround, FezVrasta/bootstrap-material-design@622fbab is working just fine and allows us to make the build pass.
This means we can proceed with #1004.

Still waiting for Bootstrap to reintroduce the javascript source tho.

@FezVrasta FezVrasta changed the title v4 build failing with latest bootstrap#v4-dev V4: build failing with latest bootstrap#v4-dev Aug 1, 2016
@FezVrasta
Copy link
Contributor

Latest v4-dev of BS includes the sources, this fixes our problem.

@FezVrasta
Copy link
Contributor

Locally it passes, on travis it fails. I'm investigating the issue

@FezVrasta FezVrasta reopened this Aug 5, 2016
@FezVrasta
Copy link
Contributor

FezVrasta commented Aug 5, 2016

Ok nice, now even locally I get:

    Task: [rollup:umd]
  Plugin: [rollup]
   Error: Error transforming /Users/federicozivolo/Progetti/bootstrap-material-design/js/index.js with 'babel' plugin: It looks like your Babel configuration specifies a module transformer. Please disable it. If you're using the "es2015" preset, consider using "es2015-rollup" instead. See https://github.com/rollup/rollup-plugin-babel#configuring-babel for more information

@rosskevin I thought you had fixed it, do you have any clue?

It's freaking weird that even after I reverted the changes the build is still failing locally.. let's see on Travis..

PS. Failing even on Travis... maybe it's some dependency that got updated and broke the build...

@FezVrasta
Copy link
Contributor

FezVrasta commented Aug 5, 2016

Ok it's babel-preset-es2015, the newest version breaks something. The 6.9.0 works just fine..

@rosskevin do you know where should we report this problem?

@FezVrasta
Copy link
Contributor

Passing both locally and on TravisCI.. for now I'll keep 6.9.0.. I don't have the knowledge to dive into the build system built by Ross

@FezVrasta
Copy link
Contributor

Seems like we could fix the problem with this suggestion?

chrisprice/grunt-rollup#18 (comment)

@FezVrasta
Copy link
Contributor

@rosskevin I can't really understand how the build system you built works... I'm thinking about rewriting it from scratch with Grunt and nothing else, I don't really see the advantages of using all this complex stuff just to run rollup and few commands...

@rosskevin
Copy link
Contributor Author

I have no objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants