Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Assert statements to crypto calls in MCUboot #2192

Open
Karambite opened this issue Jan 28, 2025 · 1 comment
Open

Add Assert statements to crypto calls in MCUboot #2192

Karambite opened this issue Jan 28, 2025 · 1 comment

Comments

@Karambite
Copy link
Contributor

Karambite commented Jan 28, 2025

I'm open to any discussion, but I think there should be asserts in instances like this.

When porting a unique crypto library, it is understood that the developer should handle errors, however, in mcuboot, an error doesn't end the mcuboot hash operation early. Instead it still continues till the hash check is incorrect. An assert here to make sure that if there are errors (like failed crypto engine boot) and end mcuboot crypto operation end earlier would be an improvement.

@Karambite
Copy link
Contributor Author

Just checking in on this, any inputs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant