released at 0.1.1

Author: mcpcpc

CHANGELOG

@@ -64,3 +64,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - MISRA 10.4 non-compliance.
 - Fix operator dependence.
+
+## [0.1.1] - 2020-11-21
+### Added
+- Makefile warnings (e.g. -Wall, Wextra, etc.).

Makefile

@@ -1,11 +1,11 @@
 .POSIX:
-CC     = cc
-CFLAGS = -W -O
+ALL_WARNING = -Wall -Wextra -pedantic
+ALL_LDFLAGS = -lxcb -lxcb-keysyms $(LDFLAGS)
+ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS) -std=c99 $(ALL_WARNING)
 PREFIX = /usr/local
 LDLIBS = -lm
 BINDIR = $(PREFIX)/bin
 MANDIR = $(PREFIX)/share/man
-LDFLAGS_REQUIRED = -lxcb -lxcb-keysyms
 
 all: xwm
 install: all
@@ -16,8 +16,9 @@ install: all
 	chmod 755 $(DESTDIR)$(BINDIR)/xwm
 	chmod 644 $(DESTDIR)$(MANDIR)/man1/xwm.1
 xwm: xwm.o
-	$(CC) $(LDFLAGS_REQUIRED) $(LDFLAGS) -o xwm xwm.o $(LDLIBS)
+	$(CC) $(ALL_LDFLAGS) -o xwm xwm.o $(LDLIBS)
 xwm.o: xwm.c xwm.h config.h
+	$(CC) $(ALL_CFLAGS) -c xwm.c
 clean:
 	rm -f xwm *.o
 uninstall:

xwm.c

@@ -5,6 +5,8 @@
 #include "xwm.h"
 #include "config.h"
 
+#define UNUSED(x) (void)(x)
+
 static xcb_connection_t * dpy;
 static xcb_screen_t     * scre;
 static xcb_drawable_t     win;
@@ -13,10 +15,12 @@ static uint32_t           min_x = WINDOW_MIN_X;
 static uint32_t           min_y = WINDOW_MIN_Y;
 
 static void killclient(char **com) {
+    UNUSED(com);
     xcb_kill_client(dpy, win);
 }
 
 static void closewm(char **com) {
+    UNUSED(com);
     if (dpy != NULL) {
         xcb_disconnect(dpy);
     }
@@ -53,6 +57,7 @@ static void handleButtonPress(xcb_generic_event_t * ev) {
 }
 
 static void handleMotionNotify(xcb_generic_event_t * ev) {
+    UNUSED(ev);
     xcb_query_pointer_cookie_t coord = xcb_query_pointer(dpy, scre->root);
     xcb_query_pointer_reply_t * poin = xcb_query_pointer_reply(dpy, coord, 0);
     uint32_t val[2] = {1, 3};
@@ -149,13 +154,10 @@ static void handleEnterNotify(xcb_generic_event_t * ev) {
 }
 
 static void handleButtonRelease(xcb_generic_event_t * ev) {
+    UNUSED(ev);
     xcb_ungrab_pointer(dpy, XCB_CURRENT_TIME);
 }
 
-static void handleKeyRelease(xcb_generic_event_t * ev) {
-    /* nothing to see here, carry on */
-}
-
 static void handleDestroyNotify(xcb_generic_event_t * ev) {
     xcb_destroy_notify_event_t * e = (xcb_destroy_notify_event_t *) ev;
     xcb_kill_client(dpy, e->window);
@@ -232,8 +234,12 @@ static int die(char * errstr) {
     while ((* (p++)) != 0) {
         ++n;
     }
-    write(STDERR_FILENO, errstr, n);
-    return 1;
+    ssize_t o = write(STDERR_FILENO, errstr, n);
+    int ret = 1;
+    if (o < 0) {
+        ret = -1;
+    }
+    return ret;
 }
 
 static int strcmp_c(char * str1, char * str2) {
@@ -250,7 +256,7 @@ static int strcmp_c(char * str1, char * str2) {
 int main(int argc, char * argv[]) {
     int ret = 0;
     if ((argc == 2) && (strcmp_c("-v", argv[1]) == 0)) {
-        ret = die("xwm-0.1.0, © 2020 Michael Czigler, see LICENSE for details\n");
+        ret = die("xwm-0.1.1, © 2020 Michael Czigler, see LICENSE for details\n");
     }
     if ((ret == 0) && (argc != 1)) {
         ret = die("usage: xwm [-v]\n");

xwm.h

@@ -36,7 +36,6 @@ static void handleDestroyNotify(xcb_generic_event_t * ev);
 static void handleButtonPress(xcb_generic_event_t * ev);
 static void handleButtonRelease(xcb_generic_event_t * ev);
 static void handleKeyPress(xcb_generic_event_t * ev);
-static void handleKeyRelease(xcb_generic_event_t * ev);
 static void handleMapRequest(xcb_generic_event_t * ev);
 static void handleFocusIn(xcb_generic_event_t * ev);
 static void handleFocusOut(xcb_generic_event_t * ev);
@@ -47,7 +46,6 @@ static handler_func_t handler_funs[] = {
     { XCB_BUTTON_PRESS,   handleButtonPress },
     { XCB_BUTTON_RELEASE, handleButtonRelease },
     { XCB_KEY_PRESS,      handleKeyPress },
-    { XCB_KEY_RELEASE,    handleKeyRelease },
     { XCB_MAP_REQUEST,    handleMapRequest },
     { XCB_FOCUS_IN,       handleFocusIn },
     { XCB_FOCUS_OUT,      handleFocusOut },