released at 0.0.4

Author: mcpcpc

CHANGELOG

@@ -9,16 +9,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Initial release.
 
 ## [0.0.2] - 2020-11-07
-## Added
+### Added
 - Close window command (default: Win+q).
 
 ### Fixed
 - Resize crash in root window.
 
 ## [0.0.3] - 2020-11-08
-## Added
+### Added
 - Examples in the config.h file.
-- New window height and width parameters.
+- Window height and width parameters.
 
-## Removed
-- <string.h> library dependency.
+### Removed
+- string.h library dependency.
+
+## [0.0.4] - 20202-11-10
+### Added
+- Instructions for patches and the patching process.
+- Minimum window height and width parameters.
+
+### Removed
+- Unused stdarg.h library dependency.
+
+### Fixed
+- Crash when pointer x/y cords less than window origin.

README

@@ -10,8 +10,7 @@ FEATURES
 BUILD REQUIREMENTS
 ==================
 
-Other than libxcb, xwm also uses several default utilities which can be
-patched, configured or expanded to meet the users preference.
+libxcb, along with any default or user defined utility:
 
     application launcher   dmenu - https://git.suckless.org/dmenu
     terminal emulator      st - https://git.suckless.org/st
@@ -44,6 +43,17 @@ Building and installing on KISS Linux:
     kiss b xwm
     kiss i xwm
 
+PATCHES
+=======
+
+xwm is considered a minimally viable window manager solution and,
+therefore, is missing several features that many users would 
+consider "essential". For additional features, I have provided
+instructions below for patching, as well as a respository for 
+sharing and hosting user created patches:
+    https://github.com/mcpcpc/xwm-patches
+
+
 EXAMPLES
 ========
 
@@ -54,20 +64,14 @@ Usimg startx to run xwm:
     echo "exec xwm" > ~/.xinitrc
     startx
 
-Using xsetroot to set a solid background color:
-    xsetroot -solid red
-
-Using imagemagick and a shell script to set a wallpaper:
-    curl -L -o bud https://bit.ly/38aAmDt
-    chmod +x bud
-    sudo install bud /usr/bin/
-    bud ~/wallpaper/directory/
-    echo "bud ~/wallpaper/directory/ & exec xwm" > ~./xinitrc
+Using xbg to set a solid background color:
+    xbg red
 
-CREDIT
-======
+Using imagemagick to set a wallpaper:
+    display -window root background.png
 
-Special thanks to the developers of dwm, sowm, lainwm, bluem and tinywm.
+Patching xwm (after copying the *.patch into the source dir.):
+    patch -p0 < mypatch.patch
 
 CONTACT
 =======

TODO

@@ -1,4 +1,2 @@
-*   Add borders to indicate window focus
-*   Add workspaces
-*   Add minimum window size
-*   Use library call instead of execvp()
+*   Add borders to indicate window focus (as a patch?)
+*   Add workspaces (as patch)

config.h

@@ -21,8 +21,10 @@
  * window behavior
  */
 
-#define WINDOW_WIDTH  600
-#define WINDOW_HEIGHT 400
+#define WINDOW_WIDTH      600
+#define WINDOW_HEIGHT     400
+#define WINDOW_MIN_WIDTH  60
+#define WINDOW_MIN_HEIGHT 40
 
 /* ALIASED COMMANDS
  * Each space delimited argument should be passed as an additional

xwm.c

@@ -1,5 +1,4 @@
 /* See LICENSE file for license details. */
-#include <stdarg.h>
 #include <unistd.h>
 #include <xcb/xcb.h>
 #include <xcb/xcb_keysyms.h>
@@ -69,10 +68,16 @@ static void handleMotionNotify(xcb_generic_event_t * ev) {
     if ((values[2] == val[1]) && (win != 0)) {
         xcb_get_geometry_cookie_t geom_now = xcb_get_geometry(dpy, win);
         xcb_get_geometry_reply_t* geom = xcb_get_geometry_reply(dpy, geom_now, NULL);
-        values[0] = poin->root_x - geom->x;
-        values[1] = poin->root_y - geom->y;
-        xcb_configure_window(dpy, win, XCB_CONFIG_WINDOW_WIDTH
-            | XCB_CONFIG_WINDOW_HEIGHT, values);
+        if (!((poin->root_x <= geom->x) || (poin->root_y <= geom->y))) {
+            values[0] = poin->root_x - geom->x;
+            values[1] = poin->root_y - geom->y;
+            uint32_t min_x = WINDOW_MIN_WIDTH;
+            uint32_t min_y = WINDOW_MIN_HEIGHT;
+            if ((values[0] >= min_x) && (values[1] >= min_y)) {
+                xcb_configure_window(dpy, win, XCB_CONFIG_WINDOW_WIDTH
+                    | XCB_CONFIG_WINDOW_HEIGHT, values);
+            }
+        }
     }
 }
 
@@ -216,7 +221,7 @@ static int strcmp_c(char * str1, char * str2) {
 int main(int argc, char * argv[]) {
     int ret = 0;
     if ((argc == 2) && (strcmp_c("-v", argv[1]) == 0)) {
-        ret = die("xwm-0.0.3, © 2020 Michael Czigler, see LICENSE for details\n");
+        ret = die("xwm-0.0.4, © 2020 Michael Czigler, see LICENSE for details\n");
     }
     if ((ret == 0) && (argc != 1)) {
         ret = die("usage: xwm [-v]\n");