Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include "typings" field in package.json #4

Closed
rolandjitsu opened this issue Nov 30, 2015 · 5 comments
Closed

include "typings" field in package.json #4

rolandjitsu opened this issue Nov 30, 2015 · 5 comments

Comments

@rolandjitsu
Copy link

Now that the TS compiler supports module resolution via node, it would be nice not to use TSD to install the typing but instead have them included with the npm package.

@mcollina
Copy link
Owner

I'm not getting what should I do. If you would like to send a PR, I'll have a look!

@rolandjitsu
Copy link
Author

Well, for those of use that use TypeScript to write node apps, when we import something we need to add some typings that describe the internals of the library. For most of those, someone has already written some typings definitions available at TSD. But now that is not necessary as the TS compiler has a new feature where you can resolve those definitions directly from node_modules.

I am not sure what the best way to do it would be as there are a few ways as described here. I hope I made it more clear now.

@mcollina
Copy link
Owner

Unfortunately I have no time to implement this myself. However, I'd be happy to accept a PR on this regard.

@rolandjitsu
Copy link
Author

Ok, I'll give it a try :)

@mcollina
Copy link
Owner

Closing as there was no acitivity for close to 2 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants