Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis worker doesn't use amazonica credentials mechanism #471

Open
Limess opened this issue Apr 21, 2023 · 2 comments
Open

Kinesis worker doesn't use amazonica credentials mechanism #471

Limess opened this issue Apr 21, 2023 · 2 comments

Comments

@Limess
Copy link
Contributor

Limess commented Apr 21, 2023

Current amazonica.aws.kinesis/worker doesn't use amazonica.core/credentials or amazonica.core/*credentials* - it instead explicitly needs credentials to be provided.

This was a minor pain when setting up a shim to the AWS SDK V2 to support AWS SSO (https://github.com/signal-ai/amazonica-aws-sso) as I had to create a separate provider and wire it through.

@Bialogs
Copy link

Bialogs commented May 8, 2023

Perhaps off-topic for this issue.

I take part of your statement to mean that the out-of-the-box amazonica credential provider chain does not support SSO. https://github.com/signal-ai/amazonica-aws-sso adds this ability here? Would love to see that included at some point but the shim looks great for now. Thanks.

@Limess
Copy link
Contributor Author

Limess commented May 9, 2023

Hey @Bialogs - yes we've written that shim to support AWS SSO credentials using amazonica for most clients by leveraging the AWS V2 SDK, without having to modify amazonica itself - this kinesis worker is the exception we use and are aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants