Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use java-time instead of joda #411

Open
conan opened this issue Apr 25, 2019 · 5 comments
Open

Option to use java-time instead of joda #411

conan opened this issue Apr 25, 2019 · 5 comments

Comments

@conan
Copy link

conan commented Apr 25, 2019

Currently Amazonica converts java.util.Dates to org.joda.time.DateTimes. Now that we have the time API from Java 8, and good support for it in clojure, it would be great to have an option to work with the native classes, or at least to leave java.util.Dates as they are without conversion.

@henryw374
Copy link

I think just leave dates alone and/or make the conversion extensible.

interested in a PR? if so, is a breaking change (ie no joda dep) ok?

@henryw374
Copy link

PR here #431

In the meantime, it's quite straightforward to add one extend-protocol of IMarshall and one alter-var-root of to-date in your own project.

@ieugen
Copy link

ieugen commented Jan 25, 2022

I also support moving to standard libraries and dropping extra code.
Long term is easier for maintenance, including security related issues (post log4j bulnerabilities).
Less is more.

@henryw374
Copy link

yeah I actually stopped using Amazonica and use the official java v2 client directly - not difficult from Clojure & it's well documented

@Limess
Copy link
Contributor

Limess commented Oct 19, 2022

This'd be very nice to stop us from having to pull in clj-time in all our libraries. We'd prefer to not immediately have to switch to the java SDK or https://github.com/cognitect-labs/aws-api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants