Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting XRay instrumentation #384

Open
eoliphan opened this issue Jul 22, 2018 · 1 comment
Open

Supporting XRay instrumentation #384

eoliphan opened this issue Jul 22, 2018 · 1 comment

Comments

@eoliphan
Copy link

I see that amazonica now pulls in the XRay libs. I've not had a chance to dig into the code, but I'm wondering if the reflective builder could be enhanced to optionally setup Xray in a similar fashion as the Spring AOP and build instrumentation currently do for java, such that one doesn't have to explicitly setup the tracing handlers, etc for a given client.
@danielcompton
Copy link

danielcompton commented Aug 10, 2018 •
edited
Loading

I found that with these dependencies all my clients were automatically instrumented. The SDK instrumentor automatically instruments any clients.

[com.amazonaws/aws-xray-recorder-sdk-core "1.3.1"]
[com.amazonaws/aws-xray-recorder-sdk-aws-sdk "1.3.1"]
[com.amazonaws/aws-xray-recorder-sdk-aws-sdk-instrumentor "1.3.1"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielcompton @eoliphan