log PA message create and update #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddox5
approved these changes
Nov 26, 2024
| @@ -56,4 +58,17 @@ defmodule ScreenplayWeb.PaMessagesApiController do | |||
| |> json(%{error: "not_found"}) | |||
| end | |||
| end | |||
|
|
|||
| defp log_pa_message(event, message, conn) do | |||
| Screenplay.Util.log(event, | |||
There was a problem hiding this comment.
I know it isn't called out in the task, but should we include alert_id? Just want to mention it in case it was an oversight.
| @@ -30,14 +30,16 @@ defmodule ScreenplayWeb.PaMessagesApiController do | |||
| end | |||
|
|
|||
| def create(conn, params) do | |||
| with {:ok, _} <- PaMessages.create_message(params) do | |||
| with {:ok, message} <- PaMessages.create_message(params) do | |||
There was a problem hiding this comment.
Do you think it's worth it to log failures that make it to the FallbackController? We may not specifically know which even failed but would be notified when they happen.
There was a problem hiding this comment.
I don't think so, since those don't result in any actual changes, and it sounds like the purpose of this logging is to monitor operational changes being made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: Add log entry to capture PA message create/update
This adds log entries for PA message create/update actions, as specified