feat: Static Templates #567
Conversation
| else | ||
| conn | ||
| |> put_status(404) | ||
| |> json(%{error: "not_found"}) | ||
| end | ||
| end | ||
|
|
||
| def static_templates(conn, _) do |
There was a problem hiding this comment.
Apologies if this was already discussed, but do we need to serve these from the backend? I was imagining just compiling the template text into the frontend bundle and accessing it statically, since that's the only place we need it.
There was a problem hiding this comment.
I don't think server vs. client was ever discussed, but that's an interesting idea. It didn't click until now that the server has no reason to care about the contents of the file. That should simplify some things so I can give that a shot and see how we feel.
priv/config/static_templates.json
Outdated
There was a problem hiding this comment.
Looks like there are two copies of this file.
There was a problem hiding this comment.
Thanks. Forgot to delete the test fixture as well.
| } | ||
| }; | ||
|
|
||
| let content; |
There was a problem hiding this comment.
nit: Since we're just returning the content immediately, we could put return statements inside each if and avoid a let here.
| onCancel={() => setPage(Page.MAIN)} | ||
| onSelect={(template) => { | ||
| setSelectedTemplate(template); | ||
| setVisualText(template.audio_text); |
There was a problem hiding this comment.
This should be:
| setVisualText(template.audio_text); | |
| setVisualText(template.visual_text); |
This PR adds a static templates feature. We will keep a list of static templates in
priv/config/static_templates.json. When a message is created using a template:I have also added an
archivedfield to each static template in order to prevent IDs from being reused by mistake. If a template is deleted and the ID is used again later, any message linked to the deleted template would then be incorrectly linked to the new one. This is unlikely to happen, but wanted to prevent it nonetheless.