chore: quiet console.error in api.test.ts (#202)

Author: skyqrose

Diff for: eslint.config.mjs

@@ -95,6 +95,8 @@ export default tseslint.config(
       "@typescript-eslint/no-empty-function": "off",
       // expect.any is untyped and triggers this all the time.
       "@typescript-eslint/no-unsafe-assignment": "off",
+      // sometimes the easiest way to mock a complex test setup is to mutate something
+      "better-mutation/no-mutation": "off",
       /* we do `view = render(); view.getBy()` which also doesn't require destructuring
       and has less global mutable state than `screen`. */
       "testing-library/prefer-screen-queries": "off",

Diff for: js/test/api.test.ts

@@ -123,6 +123,14 @@ describe("get", () => {
 });
 
 describe("useApiResult", () => {
+  let spyConsoleError: jest.SpiedFunction<typeof console.error>;
+  beforeEach(() => {
+    spyConsoleError = jest.spyOn(console, "error");
+  });
+  afterEach(() => {
+    spyConsoleError.mockRestore();
+  });
+
   test("returns loading state", () => {
     const RawData = z.string();
     const parser = (s: string) => s;
@@ -167,8 +175,10 @@ describe("useApiResult", () => {
     const RawData = z.string();
     const parser = (s: string) => s;
 
-    const { promise, resolve } = PromiseWithResolvers<Response>();
+    // this test triggers console.error. quiet it.
+    spyConsoleError.mockImplementationOnce(() => {});
 
+    const { promise, resolve } = PromiseWithResolvers<Response>();
     jest.mocked(fetch).mockReturnValue(promise);
 
     const { result } = renderHook(useApiResult, {
@@ -192,8 +202,10 @@ describe("useApiResult", () => {
     const RawData = z.string();
     const parser = (s: string) => s;
 
-    const { promise, resolve } = PromiseWithResolvers<Response>();
+    // this test triggers console.error. quiet it.
+    spyConsoleError.mockImplementationOnce(() => {});
 
+    const { promise, resolve } = PromiseWithResolvers<Response>();
     jest.mocked(fetch).mockReturnValue(promise);
 
     const { result } = renderHook(useApiResult, {
@@ -218,8 +230,10 @@ describe("useApiResult", () => {
     const RawData = z.string();
     const parser = (s: string) => s;
 
-    const { promise, resolve } = PromiseWithResolvers<Response>();
+    // this test triggers console.error. quiet it.
+    spyConsoleError.mockImplementationOnce(() => {});
 
+    const { promise, resolve } = PromiseWithResolvers<Response>();
     jest.mocked(fetch).mockReturnValue(promise);
 
     const { result } = renderHook(useApiResult, {

Diff for: js/test/helpers/metadata.ts

@@ -1,4 +1,3 @@
-/* eslint-disable better-mutation/no-mutation */
 import { MetaDataKey } from "../../util/metadata";
 
 export const putMetaData = (key: MetaDataKey, value: string) => {

Diff for: js/test/helpers/promiseWithResolvers.ts

@@ -20,9 +20,7 @@ export const PromiseWithResolvers = <T>(): {
   let resolve: ((value: T | PromiseLike<T>) => void) | undefined = undefined;
   let reject: ((reason?: unknown) => void) | undefined = undefined;
   const promise = new Promise<T>((res, rej) => {
-    // eslint-disable-next-line better-mutation/no-mutation
     resolve = res;
-    // eslint-disable-next-line better-mutation/no-mutation
     reject = rej;
   });