Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JS type checking, bump vitest and others #86

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

mbland
Copy link
Owner

@mbland mbland commented Jan 18, 2024

This builds upon my recent experience improving the type checking in:

  • mbland/jsdoc-cli-wrapper
  • mbland/test-page-opener
  • mbland/rollup-plugin-handlebars-precompiler

Switched from jsconfig.json to tsconfig.json, which seems to be better supported by default. Moved a bunch of tsc compiler options to that file and updated the pnpm typecheck script accordingly.

The generated JSDoc output still isn't the greatest, but the Visual Studio Code and IntelliJ IDEA type checking and documentation is pretty good now. I may have to circle back to improving the JSDoc output later, but I need a break from it for now.

Also, bumped vitest to v1.2.1, along with a couple other module versions.

This builds upon my recent experience improving the type checking in:

- mbland/jsdoc-cli-wrapper
- mbland/test-page-opener
- mbland/rollup-plugin-handlebars-precompiler

Switched from jsconfig.json to tsconfig.json, which seems to be better
supported by default. Moved a bunch of `tsc` compiler options to that
file and updated the `pnpm typecheck` script accordingly.

The generated JSDoc output still isn't the greatest, but the Visual
Studio Code and IntelliJ IDEA type checking and documentation is pretty
good now. I may have to circle back to improving the JSDoc output later,
but I need a break from it for now.

Also, bumped vitest to v1.2.1, along with a couple other module
versions.
@mbland mbland self-assigned this Jan 18, 2024
@mbland mbland merged commit a3f6693 into main Jan 18, 2024
3 checks passed
@mbland mbland deleted the improved-type-checking branch January 18, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant