Commit ff1a079
committed
Use Protobuf v25.5 in test_scala_version
As mentioned in the comments, Protobuf v25.5 is the maximum version
supported by ScalaPB 0.9.8 (for Scala 2.11) and 0.11.17.
This change sets up a future change to conditionally set Protobuf to
v25.5 when testing Scala 2.11 after other Scala version update to
ScalaPB 1.0.0-alpha.1. The test will use Protobuf v28.3 with those other
Scala versions.
Protobuf versions v26.x and v27.x aren't supported by any ScalaPB
version.
The `RULES_SCALA_TEST_ONLY` environment variable was invaluable for
determining these parameters, as it allowed quickly trying versions with
commands like:
```txt
$ RULES_SCALA_TEST_ONLY='test_scala_version 2.11.12' ./test_version.sh
```1 parent 2e097e4 commit ff1a079
2 files changed
+13
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
52 | 60 | | |
| 61 | + | |
| 62 | + | |
53 | 63 | | |
54 | 64 | | |
55 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
0 commit comments