Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2038] Remove appointment model #982

Merged
merged 2 commits into from
Jan 29, 2024
Merged

[#2038] Remove appointment model #982

merged 2 commits into from
Jan 29, 2024

Conversation

pi-sigma
Copy link
Contributor

Taiga: #2038

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c63452b) 94.77% compared to head (f940bd9) 94.77%.
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #982   +/-   ##
========================================
  Coverage    94.77%   94.77%           
========================================
  Files          861      862    +1     
  Lines        30192    30173   -19     
========================================
- Hits         28614    28596   -18     
+ Misses        1578     1577    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review January 23, 2024 09:46
Bartvaderkin
Bartvaderkin reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Did you check for fixtures etc? Like admin index, permissions etc?

Also I note I see no application or test code removal, was this code this dead?

@pi-sigma pi-sigma force-pushed the feature/2038-remove-appointment-model branch from 0e30ba6 to f940bd9 Compare January 23, 2024 10:40
@pi-sigma
Copy link
Contributor Author

I updated the fixtures and messages. Apparently, the code was not used at all.

Bartvaderkin
Bartvaderkin approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 👍

@stevenbal stevenbal merged commit 92d5105 into develop Jan 29, 2024
14 checks passed
@stevenbal stevenbal deleted the feature/2038-remove-appointment-model branch January 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bartvaderkin Bartvaderkin Bartvaderkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-sigma @codecov-commenter @Bartvaderkin @stevenbal