⬆️ [#2040] Upgrade python to 3.11 and zgw-consumers to 0.28.0 #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/2040-upgrade-zgw-consumers
branch
6 times, most recently
from
568b8fd
to
65a18c1
Compare
stevenbal
changed the title
stevenbal
force-pushed
the
feature/2040-upgrade-zgw-consumers
branch
2 times, most recently
from
c7df082
to
4bad33b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #977 +/- ##
===========================================
- Coverage 94.77% 94.74% -0.03%
===========================================
Files 861 862 +1
Lines 30310 30265 -45
===========================================
- Hits 28726 28676 -50
- Misses 1584 1589 +5 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
feature/2040-upgrade-zgw-consumers
branch
2 times, most recently
from
16d2a3c
to
d2c092b
Compare
|
Depends on upgrading cindy+sandra to Debian 12 |
pi-sigma
approved these changes
Jan 25, 2024
Bartvaderkin
approved these changes
Jan 26, 2024
| @@ -1 +1 @@ | |||
| 3.9 | |||
| 3.11 | |||
There was a problem hiding this comment.
Github's 2-way changes diff warns there is no newline here now, not sure if that is something.
Comment on lines
+60
to
+84
| class JSONParserClient(APIClient): | ||
| """ | ||
| Simple layer on top of `ape_pie.APIClient` to attempt to convert the response to | ||
| JSON and check that the request is successful (and raise the correct exceptions if not) | ||
| """ | ||
|
|
||
| def request( | ||
| self, | ||
| *args, | ||
| **kwargs, | ||
| ) -> Union[List[Object], Object]: | ||
| response = super().request(*args, **kwargs) | ||
| try: | ||
| response_json = response.json() | ||
| except Exception: | ||
| response_json = None | ||
|
|
||
| try: | ||
| response.raise_for_status() | ||
| except requests.HTTPError as exc: | ||
| if response.status_code >= 500: | ||
| raise | ||
| raise ClientError(response_json) from exc | ||
|
|
||
| return response_json |
There was a problem hiding this comment.
Feels weird this is not part of either apie_pie or ZGW-consumers but heh.
There was a problem hiding this comment.
I agree, I think we'll want this for more projects
stevenbal
force-pushed
the
feature/2040-upgrade-zgw-consumers
branch
from
d2c092b
to
5073d70
Compare
|
Mag gemerged worden zodra de conflicts zijn geresolved |
to fix migration crash in combination with zgw-consumers==0.27.0
because zgw-consumers 0.28.0 uses ape-pie as its client, which no longer does OAS fetching/parsing to determine request paths
stevenbal
force-pushed
the
feature/2040-upgrade-zgw-consumers
branch
from
5073d70
to
cedcd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2040
This PR upgrades to python3.11 and zgw-consumers to 0.28.0, in this new version of zgw-consumers we no longer do schema parsing to determine request paths, which removes latency that was caused by that
Notes:
get_paginated_resultsdoesn't work with the new client, created another issue for this -> https://taiga.maykinmedia.nl/project/open-inwoner/task/2060