Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#2024] Split email templates for zaak status/document notification #975

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jan 19, 2024

@stevenbal stevenbal marked this pull request as draft January 19, 2024 15:16
@stevenbal stevenbal force-pushed the feature/2024-email-notif-different-types branch 4 times, most recently from d985ed4 to 6d896ca Compare January 19, 2024 15:42
@stevenbal stevenbal marked this pull request as ready for review January 19, 2024 15:44
@stevenbal stevenbal requested a review from alextreme January 19, 2024 15:44
@alextreme alextreme requested review from Bartvaderkin and pi-sigma and removed request for alextreme January 19, 2024 15:47
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (794d3ba) 94.79% compared to head (d985ed4) 94.76%.

❗ Current head d985ed4 differs from pull request most recent head 6d896ca. Consider uploading reports for the commit 6d896ca to get more accurate results

Files Patch % Lines
...ions/0042_case_notification_mail_template_split.py 47.36% 10 Missing ⚠️
src/open_inwoner/openzaak/notifications.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
- Coverage    94.79%   94.76%   -0.04%     
===========================================
  Files          859      860       +1     
  Lines        30120    30141      +21     
===========================================
+ Hits         28553    28563      +10     
- Misses        1567     1578      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/open_inwoner/conf/parts/maileditor.py Show resolved Hide resolved
src/open_inwoner/conf/parts/maileditor.py Outdated Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/2024-email-notif-different-types branch from 6d896ca to f043339 Compare January 22, 2024 10:11
@stevenbal stevenbal requested a review from pi-sigma January 22, 2024 10:11
@alextreme alextreme merged commit c63452b into develop Jan 22, 2024
14 checks passed
@alextreme alextreme deleted the feature/2024-email-notif-different-types branch January 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants