[#2032] Make submodule update from main branch #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alextreme would this be the correct way to do it? What if I update the design-token package? Will everyone be able to automatically update or will developers have to manually pull from Main? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #965 +/- ##
========================================
Coverage 94.80% 94.80%
========================================
Files 857 857
Lines 30068 30068
========================================
Hits 28507 28507
Misses 1561 1561 ☔ View full report in Codecov by Sentry. |
|
@jiromaykin thanks this at least will avoid confusion which version of the design token package the submodule points to. Updating the submodule is done manually, afaik there isn't a way to force this to be in sync |
alextreme
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: also connected to #909 maybe connecting to a tag in future