Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [#1959] Add auto redirect to link for ProductDetail #950

Merged
merged 2 commits into from
Jan 12, 2024
Merged

✨ [#1959] Add auto redirect to link for ProductDetail #950

merged 2 commits into from
Jan 12, 2024

Conversation

stevenbal
Copy link
Contributor

alextreme
alextreme requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Failing parallel test will be picked up in 1916 so can be ignored

Please also add this feature to Categories / Onderwerp DetailView

@stevenbal stevenbal force-pushed the feature/1959-product-redirect-to-url branch from c400249 to 76069d4 Compare January 12, 2024 09:53
alextreme
alextreme approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lijkt me prima zo dank!

@alextreme alextreme merged commit 34f4146 into develop Jan 12, 2024
13 of 14 checks passed
@alextreme alextreme deleted the feature/1959-product-redirect-to-url branch January 12, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenbal @alextreme