[#1971] Double-check if our current status is an eindstatus due to eS… #923
Conversation
…uite having multiple eindstatusses
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #923 +/- ##
========================================
Coverage 92.96% 92.96%
========================================
Files 820 820
Lines 28400 28402 +2
========================================
+ Hits 26402 26404 +2
Misses 1998 1998 ☔ View full report in Codecov by Sentry. |
| @@ -172,6 +172,15 @@ def get_context_data(self, **kwargs): | |||
| # The end status data is not passed if the end status has been reached, | |||
| # because in that case the end status data is already included in `statuses` | |||
| end_statustype = next((s for s in statustypen if s.is_eindstatus), None) | |||
There was a problem hiding this comment.
@alextreme Wouldn't this line become irrelevant after the changes you made? If I understand it correctly, the conditional below would always be triggered and override end_statustype to be the statustype of the last status (if is_eindstatus is True) right?
There was a problem hiding this comment.
I indeed went for the most minimal change for my hotfix for v1.12. I suspect you're correct and have updated this branch to remove this line and avoid future confusion
There was a problem hiding this comment.
Hmm okay I may have been wrong, I glanced over that fact that in this line the statustypen are used directly, so that way we will still get the end_statustype even if this status hasn't been reached yet, so I think we still need this line 😅
I removed the change.
stevenbal
force-pushed
the
issue/1971-check-current-status-for-eindstatus
branch
from
fd80cea
to
2bfc809
Compare
…uite having multiple eindstatusses