Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1991] StatusTypeConfig configuration not refreshing #917

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

alextreme
Copy link
Member

@alextreme alextreme commented Dec 29, 2023

task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1991

init is only called once upon app start, not per pageview

https://stackoverflow.com/questions/46599145/django-class-view-init

And we also need to filter the statustypeconfig/resulttypeconfigs on the zaaktypeconfig, as the eSuite has one statustype linked to multiple zaaktypes. Otherwise we most likely are using the statustypeconfig from a different zaaktype

…ly called once upon app start, not per pageview)
@alextreme
Copy link
Member Author

Mostly FYI

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff6dba9) 92.96% compared to head (064a2e1) 92.96%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #917   +/-   ##
========================================
  Coverage    92.96%   92.96%           
========================================
  Files          820      820           
  Lines        28392    28394    +2     
========================================
+ Hits         26394    26396    +2     
  Misses        1998     1998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ntificatie to avoid duplicates from the eSuite
@alextreme
Copy link
Member Author

Failing tests: (open_inwoner.openzaak.tests.test_case_detail.TestCaseDetailView)

  • test_pass_endstatus_type_data_if_endstatus_not_reached
  • test_status_is_retrieved_when_user_logged_in_via_digid

I suspect that the additional filtering of statustype/resultaattypeconfig on zaaktype.identificatie means that the mocked-responses need to be expanded to ensure the statustypeconfig's are properly picked up

@alextreme
Copy link
Member Author

Leaving this for now due to timeconstraints, either of you can pick this up to complete the PR by fixing the failing tests. I will cherry-pick these commits for in the next v1.12 release as these caused blocking issues

@stevenbal stevenbal self-assigned this Jan 2, 2024
@stevenbal
Copy link
Contributor

I'll pick this up

@stevenbal stevenbal merged commit dc412cd into develop Jan 2, 2024
14 checks passed
@stevenbal stevenbal deleted the issue/1991-statustypeconfig-not-refreshing branch January 2, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants