[#1938] Added theme stylesheet field to SiteConfiguration #911
Conversation
Bartvaderkin
force-pushed
the
feature/1938-theme-stylesheet-field
branch
from
6f7133e
to
92d3b49
Compare
| @@ -136,6 +136,7 @@ class SiteConfigurarionAdmin(OrderedInlineModelAdminMixin, SingletonModelAdmin): | |||
| "primary_font_color", | |||
| "secondary_font_color", | |||
| "accent_font_color", | |||
| "theme_stylesheet", | |||
There was a problem hiding this comment.
Works really nice! I do wonder if it is wise to put this button in this section here? We decided to 'hide' the other CSS field much lower in the Admin config at 'Geavanceerde opties' - and I guess that's the one that overrides everything as a final last load? So this uploaded file is not the last one loaded? (which is fine actually)
There was a problem hiding this comment.
@jiromaykin Good point, I moved it in the admin to the same part as the extra CSS.
And you are correct this uploaded file is placed before the extra CSS field, seems most sensible but we can change it if necessary.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #911 +/- ##
========================================
Coverage 92.92% 92.93%
========================================
Files 818 819 +1
Lines 28212 28233 +21
========================================
+ Hits 26217 26238 +21
Misses 1995 1995 ☔ View full report in Codecov by Sentry. |
No description provided.