[#1951] Add userfeed frontend component #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #910 +/- ##
========================================
Coverage 92.93% 92.93%
========================================
Files 819 819
Lines 28250 28250
========================================
Hits 26255 26255
Misses 1995 1995 ☔ View full report in Codecov by Sentry. |
jiromaykin
changed the title
jiromaykin
force-pushed
the
feature/1951-userfeed-frontend-component
branch
from
e540ab0
to
c61575d
Compare
pi-sigma
requested changes
Dec 21, 2023
src/open_inwoner/components/templates/components/UserFeed/UserFeed.html
Outdated
Show resolved
Hide resolved
src/open_inwoner/components/templates/components/UserFeed/UserFeed.html
Outdated
Show resolved
Hide resolved
src/open_inwoner/components/templates/components/UserFeed/UserFeed.html
Outdated
Show resolved
Hide resolved
| line-height: var(--font-line-height-body); | ||
| position: relative; | ||
| overflow: hidden; | ||
| z-index: 1002; |
There was a problem hiding this comment.
That's very specific. What's the rationale for this value (no objection, just curious)?
There was a problem hiding this comment.
You mean the Z-index? That's indeed my mistake 😞 - the other stuff is needed to prepare positioning for the pseudo-element (= the pipe symbol between list-items).
jiromaykin
force-pushed
the
feature/1951-userfeed-frontend-component
branch
2 times, most recently
from
8c573e9
to
349e7e9
Compare
jiromaykin
force-pushed
the
feature/1951-userfeed-frontend-component
branch
from
c48a06e
to
dffd357
Compare
pi-sigma
approved these changes
Dec 21, 2023
|
Besproken @Bartvaderkin kijkt nog ter afronding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1951
This 'placeholder' template, showing 2 cards, is not dynamic yet! Depends on Taiga issue #1760.
Design: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=717%3A12249&mode=dev
The Danger/Warning color is default for Actions - when back-end is done, the 2 cards can be merged into 1 with dynamic CSS classes.
➕ adding new pattern for H2's that need to have an indicator dot.