Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1932] Skipping zaaktype in case identificatie doesn't exist in zaaktype list #892

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

alextreme
Copy link
Member

@alextreme alextreme commented Dec 11, 2023

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3bc521) 92.81% compared to head (1ce761d) 92.91%.
Report is 35 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #892      +/-   ##
===========================================
+ Coverage    92.81%   92.91%   +0.10%     
===========================================
  Files          802      817      +15     
  Lines        27525    28027     +502     
===========================================
+ Hits         25547    26041     +494     
- Misses        1978     1986       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal
Copy link
Contributor

Apparently if Zaaktypen are linked to the Category for which the user has no Zaken, this error occurred. Not sure how I never ran into this 😅

Updated the tests so this is tested as well

@stevenbal stevenbal changed the title [#1932] Skipping zaaktype in case identificatie doesn't exist in zaak… [#1932] Skipping zaaktype in case identificatie doesn't exist in zaaktype list Dec 14, 2023
@stevenbal stevenbal merged commit 72bd3a2 into develop Dec 14, 2023
14 checks passed
@stevenbal stevenbal deleted the issue/1932-keyerror-zaaktype-identificatie branch December 14, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants