[#1928] Check missing volgnummer for second status preview #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
fix/1928-statustype-missing-volgnummer
branch
from
0247c7c
to
4993699
Compare
stevenbal
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Code looks good 👍
@alextreme not entirely sure if this solution is approved in the comments in taiga yet, so I'll wait with merging
|
Pushing this through in spite of concerns, it's not like we have an option here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InnerCaseDetailView.get_second_status_previewoccasionally failed due to aTypeErrorbecause case status types retrieved via the eSuite don't always contain avolgnummer.I added a check to the function and updated the annotation of our
StatusTypeapi modelTaiga #1928