🐛 [#1904] Fix Case list crashing due to reused Statustypen #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1904 if the ZGW APIs reuse StatusTypen for different ZaakTypen, we end up with multiple `ZaakTypeStatusTypeConfig` that have the same `statustype_url`, which led to errors when retrieving these configs. To fix this we explicitly filter for the correct `ZaakTypeConfig` as well
stevenbal
force-pushed
the
issue/1904-case-list-failure-zaaktypestatustypeconfig
branch
2 times, most recently
from
2a27bc1
to
9851e94
Compare
pi-sigma
requested changes
Dec 4, 2023
stevenbal
force-pushed
the
issue/1904-case-list-failure-zaaktypestatustypeconfig
branch
from
9851e94
to
a1de2a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #876 +/- ##
========================================
Coverage 92.80% 92.81%
========================================
Files 800 802 +2
Lines 27495 27525 +30
========================================
+ Hits 25517 25547 +30
Misses 1978 1978 ☔ View full report in Codecov by Sentry. |
alextreme
approved these changes
Dec 4, 2023
pi-sigma
approved these changes
Dec 4, 2023
alextreme
deleted the
issue/1904-case-list-failure-zaaktypestatustypeconfig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1904
if the ZGW APIs reuse StatusTypen for different ZaakTypen, we end up with multiple
ZaakTypeStatusTypeConfigthat have the samestatustype_url, which led to errors when retrieving these configs. To fix this we explicitly filter for the correctZaakTypeConfigas well