[#1883] Fix override file uploads per status type #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
fix/1883-file-upload-statustype
branch
3 times, most recently
from
6494ace
to
fa8e0de
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #865 +/- ##
===========================================
- Coverage 92.80% 92.79% -0.01%
===========================================
Files 798 797 -1
Lines 27422 27450 +28
===========================================
+ Hits 25449 25473 +24
- Misses 1973 1977 +4 ☔ View full report in Codecov by Sentry. |
jiromaykin
reviewed
Nov 30, 2023
stevenbal
approved these changes
Nov 30, 2023
| @@ -234,12 +241,9 @@ def get_context_data(self, **kwargs): | |||
|
|
|||
| return context | |||
|
|
|||
| def add_second_status_preview(self, statuses: list, statustypen: list) -> None: | |||
| def get_second_status_preview(self, statustypen: list) -> Optional[StatusType]: | |||
There was a problem hiding this comment.
Just to double check: this is to get the preview of the actual second status and not the next status, right?
jiromaykin
requested changes
Nov 30, 2023
pi-sigma
force-pushed
the
fix/1883-file-upload-statustype
branch
4 times, most recently
from
a49f645
to
1da2ead
Compare
pi-sigma
force-pushed
the
fix/1883-file-upload-statustype
branch
from
1da2ead
to
245dfdd
Compare
jiromaykin
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File uploads could be enabled/disabled per case type, but overriding this per status type did not work because the preview for the upcoming second case status was handled inconsistently between back-end and fron-end.
Taiga #1833