✨ [#1878] Post-login registration form for eHerkenning

[stevenbal]

Based on #859, so that should be merged first

task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1878

Aside from adapting the necessary registration form, the following was also changed/added:

• added eHerkenning link to registration page
• made DigiD/eHerkenning links on registration page conditional based on settings.DIGID_ENABLED and SiteConfiguration.eherkenning_enabled

[stevenbal]

I removed the first and last name fields from this form, I did notice however that the generated email is prefilled in the form:

I'm not sure if this is intentional, do we want this? @alextreme

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2d0fb26) 92.68% compared to head (edfd210) 92.75%.

Files	Patch %	Lines
src/open_inwoner/accounts/views/registration.py	50.00%	2 Missing ⚠️

Additional details and impacted files

@@                              Coverage Diff                               @@
##           feature/1866-kvk-onderwerp-personalization     #861      +/-   ##
==============================================================================
+ Coverage                                       92.68%   92.75%   +0.06%     
==============================================================================
  Files                                             788      788              
  Lines                                           27050    27155     +105     
==============================================================================
+ Hits                                            25071    25187     +116     
+ Misses                                           1979     1968      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alextreme]

I removed the first and last name fields from this form, I did notice however that the generated email is prefilled in the form:

I'm not sure if this is intentional, do we want this? @alextreme

How we deal with emailadresses and DigiD is a bit odd, but as it's a required field it is auto-generated. I'd recommend to do the same with eHerkenning, and if it's auto-generated that we hide this value just like with DigiD (it is overwritten anyway).

[stevenbal]

and if it's auto-generated that we hide this value just like with DigiD (it is overwritten anyway).

Ah I see, I'll implement it the same for eHerkenning

[alextreme]

Looks good to me