Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#1866] Enable category personalization based on KvK number #859

Conversation

stevenbal
Copy link
Contributor

Based on #854, so that should be merged first

task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1866

@stevenbal stevenbal marked this pull request as draft November 23, 2023 11:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa56c78) 92.66% compared to head (2d0fb26) 92.68%.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           feature/1855-eherkenning-login     #859      +/-   ##
==================================================================
+ Coverage                           92.66%   92.68%   +0.02%     
==================================================================
  Files                                 788      788              
  Lines                               27047    27050       +3     
==================================================================
+ Hits                                25062    25071       +9     
+ Misses                               1985     1979       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal marked this pull request as ready for review November 23, 2023 11:58
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I would remove some comments.

src/open_inwoner/accounts/tests/factories.py Outdated Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/1866-kvk-onderwerp-personalization branch from c1888f0 to c788c6b Compare November 27, 2023 08:27
@stevenbal stevenbal force-pushed the feature/1855-eherkenning-login branch 2 times, most recently from 74b3584 to fa56c78 Compare November 27, 2023 10:15
@alextreme alextreme merged commit c70adff into feature/1855-eherkenning-login Nov 27, 2023
11 checks passed
@alextreme alextreme deleted the feature/1866-kvk-onderwerp-personalization branch November 27, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants