Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1769] Replace deprecated djchoices with native Django choices #846

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[#1769] Replace deprecated djchoices with native Django choices #846

merged 1 commit into from
Nov 16, 2023

Conversation

pi-sigma
Copy link
Contributor

Taiga #1769

@pi-sigma pi-sigma force-pushed the feature/1769-refactor-django-choices branch from c2a6520 to 40586b6 Compare November 13, 2023 15:09
@stevenbal stevenbal marked this pull request as ready for review November 14, 2023 10:52
stevenbal
stevenbal requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good overall

src/open_inwoner/accounts/choices.py Show resolved Hide resolved
src/open_inwoner/accounts/choices.py Show resolved Hide resolved
src/open_inwoner/accounts/models.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/tests/test_action_views.py Show resolved Hide resolved
src/open_inwoner/accounts/tests/test_action_views.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/tests/test_action_views.py Outdated Show resolved Hide resolved
src/open_inwoner/management/commands/generate_native_django_choices.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/constants.py Outdated Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the feature/1769-refactor-django-choices branch from 40586b6 to 8ebb90c Compare November 14, 2023 13:32
@stevenbal stevenbal merged commit 0af2a12 into develop Nov 16, 2023
16 checks passed
@stevenbal stevenbal deleted the feature/1769-refactor-django-choices branch November 16, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbal stevenbal stevenbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pi-sigma @stevenbal