✨ [#1821] Add visibility flags for Category model #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/1821-onderwerp-visibility-flags
branch
from
23807d8
to
2fc7686
Compare
category detail pages are still accessible if directly navigated to implemented for: * category list in menu * highlighted categories on homepage * category list page
stevenbal
force-pushed
the
feature/1821-onderwerp-visibility-flags
branch
3 times, most recently
from
324c1d6
to
cbdfb08
Compare
stevenbal
force-pushed
the
feature/1821-onderwerp-visibility-flags
branch
from
cbdfb08
to
b66ba9a
Compare
stevenbal
changed the title
Lets give Bram and Robert time to respond to my suggestion, and leave 'Mijn Onderwerpen' out-of-scope for the time being. |
pi-sigma
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
The category detail pages are still accessible via the urls. Is this intended? If so, looking good.
I just looked up the ticket and saw that this is indeed intended, so good to go.
@stevenbal Could you include a link to the Taiga task in the first comment next time? Sometimes entering the task id in Taiga's url bar doesn't yield a result and then you have to search for the ticket.
|
@pi-sigma will do 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the basics for the visibility flags, no DigiD/eHerkenning or Zaaktype checks yet, I created separate tasks for that
@alextreme I did not apply the visibility logic for
/mijn-profiel/onderwerpen/since this is not mentioned in the issue, should this logic apply to this view as well?Taiga #1821