[#1814] Upgraded digid-eherkenning to 0.9 #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The new version validates BSN numbers during the mock login flow
pi-sigma
force-pushed
the
feature/1814-update-digid-eherkenning
branch
from
c568afb
to
47351a6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #823 +/- ##
===========================================
- Coverage 93.05% 93.04% -0.01%
===========================================
Files 744 744
Lines 25931 25939 +8
===========================================
+ Hits 24130 24136 +6
- Misses 1801 1803 +2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bartvaderkin
suggested changes
Oct 24, 2023
Bartvaderkin
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version validates BSN numbers during the mock login flow.
This will prevent issues like Taiga #1814 by requiring users to enter a BSN that satifies pattern validation as well as the 11-check.