-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1791] Update design for case statuses #821
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #821 +/- ##
===========================================
+ Coverage 93.08% 93.10% +0.02%
===========================================
Files 749 751 +2
Lines 25914 25947 +33
===========================================
+ Hits 24123 24159 +36
+ Misses 1791 1788 -3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c79602e
to
a913f0f
Compare
6e68d3f
to
5d22047
Compare
5d22047
to
b932437
Compare
@@ -116,6 +120,23 @@ def get_context_data(self, **kwargs): | |||
|
|||
statuses = fetch_status_history(self.case.url) | |||
|
|||
statustype_config_mapping = { | |||
zaaktype_statustype.statustype_url: zaaktype_statustype | |||
for zaaktype_statustype in ZaakTypeStatusTypeConfig.objects.all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be refactored in develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alextreme Do you mean there is an equivalent for this in Develop already? These values are part of Steven's commits on which I am relying to build the front-end, so I need them :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiromaykin I mean that the objects.all() call is incorrect/inefficient, but this should have already been fixed on develop. The values should remain the same afaik
a87abc7
to
944a684
Compare
3addabb
to
bdcd1d6
Compare
3d15f16
to
95a46e8
Compare
95a46e8
to
b30845d
Compare
a620642
to
eb05214
Compare
26d1b56
to
97c7d14
Compare
42575bf
to
6adabf3
Compare
src/open_inwoner/components/templates/components/StatusIndicator/StatusIndicator.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pi-sigma could you give this a final review? After that I'll merge Jiro's changes |
Just some more info about this spacing: it looks too big now because you only see the date, but this is where in a new PR the 'Zaaktype statustype description field' will be added so it will look better with more text. |
Major change issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1791
Final design: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=67%3A4147&mode=design&t=Dux8ArfAUpVuR1Ls-1
Additionally:
For testing: use BSN 111111110,