Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1791] Update design for case statuses #821

Merged
merged 11 commits into from
Nov 7, 2023

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Oct 19, 2023

Major change issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1791

Final design: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=67%3A4147&mode=design&t=Dux8ArfAUpVuR1Ls-1

  • What makes this complicated: a status can be 'current' and then needs to be 'open', but... the final status is also sort of 'current' but is not allowed to be part of the accordion; endstatuses should just be shown as 'open' visually but should not have a toggle or a caret-icon;
  • the final 'visual' status in the frontend can either be the semi-static 'future' status or the final status that is also basically current. Past statuses are shown as 'completed' and should be part of the accordion.
  • Each current status can have a configurable color.
  • The final active status after case has ended has a default Info color.

Additionally:

  • status colors, and exceptions inside exceptions in these colors
  • margins between components
  • disable button for contact-form

For testing: use BSN 111111110,

  1. Aanvraag with current active status (+ 1 past completed status) and future status: http://127.0.0.1:8000/mijn-aanvragen/1229a0d7-e52a-47f2-a524-7a9dca94d1bf/status/
  2. Aanvraag finished (with multiple completed past statuses and final) http://127.0.0.1:8000/mijn-aanvragen/054847a7-1ccb-4cd4-8768-1fff29f08cf6/status/

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #821 (28e76a9) into develop (88ae2db) will increase coverage by 0.02%.
The diff coverage is 93.02%.

@@             Coverage Diff             @@
##           develop     #821      +/-   ##
===========================================
+ Coverage    93.08%   93.10%   +0.02%     
===========================================
  Files          749      751       +2     
  Lines        25914    25947      +33     
===========================================
+ Hits         24123    24159      +36     
+ Misses        1791     1788       -3     
Files Coverage Δ
...c/open_inwoner/cms/cases/tests/test_contactform.py 100.00% <100.00%> (ø)
src/open_inwoner/cms/cases/views/status.py 88.93% <100.00%> (+0.25%) ⬆️
...open_inwoner/components/templatetags/table_tags.py 97.95% <ø> (ø)
...ner/openzaak/migrations/0027_auto_20231101_1641.py 100.00% <100.00%> (ø)
...er/openzaak/migrations/0028_merge_20231101_1705.py 100.00% <100.00%> (ø)
src/open_inwoner/openzaak/models.py 98.56% <ø> (ø)
...rc/open_inwoner/openzaak/tests/test_case_detail.py 100.00% <100.00%> (ø)
src/open_inwoner/cms/cases/tests/test_htmx.py 20.47% <0.00%> (-0.50%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin force-pushed the feature/1791-design-status-case-detail branch from c79602e to a913f0f Compare October 23, 2023 09:57
@jiromaykin jiromaykin changed the title [#1791] Update design for case detail [#1791] Update design for case statuses Oct 24, 2023
@jiromaykin jiromaykin force-pushed the feature/1791-design-status-case-detail branch 3 times, most recently from 6e68d3f to 5d22047 Compare October 27, 2023 11:02
@jiromaykin jiromaykin force-pushed the feature/1791-design-status-case-detail branch from 5d22047 to b932437 Compare October 29, 2023 23:44
@@ -116,6 +120,23 @@ def get_context_data(self, **kwargs):

statuses = fetch_status_history(self.case.url)

statustype_config_mapping = {
zaaktype_statustype.statustype_url: zaaktype_statustype
for zaaktype_statustype in ZaakTypeStatusTypeConfig.objects.all()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be refactored in develop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alextreme Do you mean there is an equivalent for this in Develop already? These values are part of Steven's commits on which I am relying to build the front-end, so I need them :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiromaykin I mean that the objects.all() call is incorrect/inefficient, but this should have already been fixed on develop. The values should remain the same afaik

@jiromaykin jiromaykin force-pushed the feature/1791-design-status-case-detail branch from a87abc7 to 944a684 Compare October 30, 2023 14:25
@jiromaykin jiromaykin force-pushed the feature/1791-design-status-case-detail branch from 3addabb to bdcd1d6 Compare October 31, 2023 17:56
@pi-sigma pi-sigma force-pushed the feature/1791-design-status-case-detail branch from 3d15f16 to 95a46e8 Compare November 1, 2023 15:47
@pi-sigma pi-sigma force-pushed the feature/1791-design-status-case-detail branch from 95a46e8 to b30845d Compare November 1, 2023 16:06
@jiromaykin jiromaykin force-pushed the feature/1791-design-status-case-detail branch from a620642 to eb05214 Compare November 2, 2023 15:46
@alextreme alextreme marked this pull request as ready for review November 3, 2023 09:28
@jiromaykin jiromaykin force-pushed the feature/1791-design-status-case-detail branch from 26d1b56 to 97c7d14 Compare November 4, 2023 00:38
@jiromaykin jiromaykin force-pushed the feature/1791-design-status-case-detail branch from 42575bf to 6adabf3 Compare November 6, 2023 08:41
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for the most part. I find the spacing between statuses and toggle on mobile/tablet too big (see screenshot), but I'll leave the decision about this to you.

Screenshot from 2023-11-06 12-48-24

@alextreme
Copy link
Member

@pi-sigma could you give this a final review? After that I'll merge Jiro's changes

@jiromaykin
Copy link
Contributor Author

jiromaykin commented Nov 7, 2023

... the spacing between statuses and toggle on mobile/tablet too big (see screenshot), but I'll leave the decision about this to you.

Just some more info about this spacing: it looks too big now because you only see the date, but this is where in a new PR the 'Zaaktype statustype description field' will be added so it will look better with more text.

@alextreme alextreme merged commit 1561c3b into develop Nov 7, 2023
14 checks passed
@alextreme alextreme deleted the feature/1791-design-status-case-detail branch November 7, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants