🐳 Fix NPM install in Docker #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrading FontAwesome caused dependency issues
|
@alextreme I'm not sure if we run Open Inwoner in docker, if not then this would have to be modified in the deployment as well |
Codecov Report
@@ Coverage Diff @@
## develop #818 +/- ##
========================================
Coverage 93.05% 93.05%
========================================
Files 744 744
Lines 25931 25931
========================================
Hits 24130 24130
Misses 1801 1801 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@stevenbal thanks, we use maykin-deployment/projects/open-inwoner for SaaS deployment, I see that this fix was already applied for that. |
alextreme
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading FontAwesome caused dependency issues